add callback to uniq method of collection #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| my %seen; | ||
| return $_[0]->new(grep { !$seen{$_}++ } @{$_[0]}); | ||
| return $self->new(map { (!$seen{ $cb->($_) }++) ? $_ : () } @$self) |
There was a problem hiding this comment.
Why not use grep instead of map?
There was a problem hiding this comment.
Just a (bad) habit, I use map far more than grep, so I use it by default. Fixed.
|
I'm neutral, leaning toward +1. |
|
I'd suggest using a better example in the docs. I like the method call example in List::UtilsBy::uniq_by |
|
👍 from me. |
CandyAngel
force-pushed
the
collection_uniq_callback
branch
from
c7b9dc1
to
d8980b3
Compare
kraih
added a commit
that referenced
this pull request
Sep 25, 2015
add callback to uniq method of collection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a callback to the uniq method in Mojo::Collection, allowing users to define what constitutes a unique element. This permits collections of hashes and arrays to be de-duplicated, rather than just elements which stringify reasonably (strings, numbers, overloaded objects).