Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Css parser fix #874

Merged
merged 4 commits into from Nov 17, 2015
Merged

Css parser fix #874

merged 4 commits into from Nov 17, 2015

Conversation

jamadam
Copy link
Contributor

@jamadam jamadam commented Nov 17, 2015

This PR improves Mojo::DOM::CSS behavior with some test cases. It's not an atomic PR (sorry) so partial merger is also welcome.

  • Reduces following Perl errors when :nth-* equation is '0'. Believe it or not, nth-child(0) is valid CSS.

Use of uninitialized value in multiplication (*) at /Users/sugamakeita/Documents/dev/mojo-fork/lib/Mojo/DOM/CSS.pm line 174, line 2125.
Use of uninitialized value in addition (+) at /Users/sugamakeita/Documents/dev/mojo-fork/lib/Mojo/DOM/CSS.pm line 174, line 2125.

  • Fixes a bug where :not pseude-class name have been unexpectedly case-sensitive.
  • Slightly faster css matching.

kraih added a commit that referenced this pull request Nov 17, 2015
@kraih
Merge pull request #874 from jamadam/css-parser-fix
08b8fbc 
Css parser fix
@kraih kraih merged commit 08b8fbc into mojolicious:master Nov 17, 2015
@kraih
Copy link
Member

kraih commented Nov 17, 2015

Thanks, applied. (and cleaned up)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jamadam @kraih