Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute Selector fails for defined attributes with wrong values in Mojo::DOM::CSS #979

Merged
merged 1 commit into from Jul 5, 2016

Conversation

Akron
Copy link
Contributor

@Akron Akron commented Jul 5, 2016

Given a tag with a defined but value-less attribute like

<input type="text" name="example" value>

(for example generated using the taghelper plugin with $c->text_field('example', value => undef)),
the CSS selector

input[value="myname"]

will match regardless of the non-fitting value.
I tested the behaviour in Firefox and assume the selector should not match.
I added a test and a patch (although I doubt the patch is optimal).

Thank you!

@kraih kraih merged commit 8da4f71 into mojolicious:master Jul 5, 2016
@kraih
Copy link
Member

kraih commented Jul 5, 2016

Thanks, applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants