Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include link to 1.0.0-beta SemVer spec #52

Closed
haacked opened this issue Mar 13, 2013 · 4 comments
Closed

Include link to 1.0.0-beta SemVer spec #52

haacked opened this issue Mar 13, 2013 · 4 comments

Comments

@haacked
Copy link
Contributor

haacked commented Mar 13, 2013

tl;dr version:

The SemVer 1.0.0 RTM spec was published twice with changes accidentally. In the first version, the dash was not required for pre-release. In the second version, it was.

The solution we came up with is to call the first version 1.0.0-beta and add a link to that version of the spec with the 1.0.0-beta label (just as we do with the RCs).

That way those that implemented that version of the 1.0.0 spec can point out that they also support this particular revision of SemVer.

For the full discussion, check out semver/semver#49

@theory
Copy link
Contributor

theory commented Mar 13, 2013

Hey @haacked, with respect to your request for a PR, I'm not sure I what should be changed in the text of the site, other than perhaps adding a link to the 1.0.0-beta (1.0.0beta? :-P)). Maybe 1.0.0 should mention the use of a hyphen? I wouldn't say it was optional, of course, though it should be optional for parsers that support both 1.0.0-beta and 1.0.0.

@haacked
Copy link
Contributor Author

haacked commented Mar 13, 2013

@theory Yeah, if you look at the site, you'll see there's links to the RCs. I was thinking just do the same for 1.0.0-beta. I can fix it up after if anything needs to be changed. But helping me get a head start is much appreciated.

@theory theory mentioned this issue Mar 20, 2013
@theory
Copy link
Contributor

theory commented Mar 20, 2013

Give that a try.

@haacked
Copy link
Contributor Author

haacked commented Aug 5, 2016

Looks like this was completed a while ago. Pro tip, if your commit includes something like "Fixes #52" then when it's merged into the default branch, it'll close the referenced issue.

@haacked haacked closed this as completed Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants