-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Previously, depending on order of libary loading, RSpec constant might not have been defined at the time the Checkpoint class was evaluated. As such, the RSpec expectations were not added to the list of `Checkpoint.rescuable_errors` even though they were defined at runtime. This makes rspec inclusion a more 'first-class' citizen and explicitly requires users to include RSpec support if they want it.
- Loading branch information
1 parent
8e1d015
commit fcd486e
Showing
3 changed files
with
10 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
require 'rspec/expectations' | ||
|
||
Capybara::UI::Checkpoint.rescuable_errors << RSpec::Expectations::ExpectationNotMetError |