ember fix

[tyleriguchi]

Ember breaks the grid system by inserting script tags around elements since nth-child is being used. I replaced nth-child with of-type. Foundation had the same bug

[monkeez]

Wouldn't this screw up though if you had different types of items in a grid?

On 11 August 2014 11:08, Tyler notifications@github.com wrote:

Ember breaks the grid system by inserting script tags around elements
since nth-child is being used. I replaced nth-child with of-type.
Foundation had the same bug

emberjs/ember.js#1893

You can merge this Pull Request by running

git pull https://github.com/tyleriguchi/jeet master

Or view, comment on, or merge it at:

#281
Commit Summary

• ember fix

File Changes

• M scss/jeet/_grid.scss
  https://github.com/mojotech/jeet/pull/281/files#diff-0 (19)
• M stylus/jeet/_grid.styl
  https://github.com/mojotech/jeet/pull/281/files#diff-1 (26)

Patch Links:

• https://github.com/mojotech/jeet/pull/281.patch
• https://github.com/mojotech/jeet/pull/281.diff

—
Reply to this email directly or view it on GitHub
#281.

[corysimmons]

Wouldn't this screw up though if you had different types of items in a grid?

This.

Why does ember surround things with script tags?

[corysimmons]

@tyleriguchi Maybe fork and keep an nth-of-type repo specifically for Ember?

[tyleriguchi]

Oh yeah you are totally right, it does fail with different tags. It'd be great to use jeet with ember though

[tyleriguchi]

@corysimmons Yeah I'll set up the repo.

[tyleriguchi]

repo is located here

[sethbrasile]

@corysimmons

Why does ember surround things with script tags?

It's how Ember handles two way data binding.

[corysimmons]

Interesting. Meteor does this via Node but Ember does this all client-side somehow?

[sethbrasile]

Yup!

If I understand correctly, they're working on doing away with this in a project called HTMLBars

[corysimmons]

Yeah, seems like anything that could be done with script tags could be done without it. Cool, excited about HTMLBars. :D