Set up GitHub workflows to run basic checks via Danger #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mokagio
force-pushed
the
danger-github-workflow-setup
branch
from
d43813a
to
7ab444b
Compare
mokagio
added
enhancement
Here's a screenshot of Danger leaving a comment about the PR not having labels.
|
Here's a screenshot showing a new workflow run after a label is added.
(That's the |
Finally, here's a screenshot of the Danger comment being gone after the label has been added.
If you try this label/unlabel process yourself, you might have to refresh the page after the GitHub Action build has finished to see comment gone. I guess GitHub updates the DOM when a new comment is posted or a check succeeds, but doesn't do it when a comment is removed. |
mokagio
force-pushed
the
danger-github-workflow-setup
branch
from
dc42f52
to
7ab444b
Compare
Here's a screenshot of Danger leaving a comment because I left a commit SHA in the `Podfile` and failing the build because of that.
|
Once the commit is rebased away, so is the failure comment.
|
mokagio
force-pushed
the
danger-github-workflow-setup
branch
from
7ab444b
to
eb8d57e
Compare
mokagio
commented
Feb 11, 2020
| # The restrictions on the types of pull_request event that can trigger this | ||
| # workflow is intentional. We only want to run these sanity checks when the | ||
| # PR is opened or reopened, or its branch receives a push. | ||
| types: [opened, reopened, synchronize] |
There was a problem hiding this comment.
For example, here you can see that after a push only the sanity checks run.
This was referenced Feb 11, 2020
…logdetail-navigation-title Fixes missing navigation title for a blog on resume
…re/13318-quick_actions_spotlight Quick Actions: Add spotlight for Quick Start tour
mokagio
force-pushed
the
danger-github-workflow-setup
branch
from
eb8d57e
to
15756c9
Compare
This brings our workflows in line with what GitHub does in their examples (https://github.com/actions/starter-workflows): - No explicit name for a job object - The job object key is a verb representing what the job does
mokagio
added
enhancement
This was referenced Feb 12, 2020
|
Closing, because wordpress-mobile#13423 has been merge upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step to implement wordpress-mobile#13366.
This adds a GitHub workflows that run the shared Peril settings to:
This setup uses the Danger GitHub Action. I like it because we don't have to add anything to our repo in order to run Danger, but it comes with a time overhead on CI because the action needs to be fetched and built.
Using the action is fine for now, I think, but we might want to do a performance comparison with a local Danger setup later on. It might be worth takin on the cost of maintaining a local setup if we can get a noticeably faster feedback loop for those opening the PR.
To test this, I'll be adding and removing labels to this PR as well as pushing (and then reverting) commits to trigger the sanity checks. If everything works, Danger will post warnings in those PRs via the GitHub Actions bot account. The bot account is what I got wrong in my previous PRs. I finally figured it thanks to the help of the Danger team.