New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR to check whether Danger JS' master makes multiple comments #4

Open

mokagio wants to merge 2 commits into master from danger-multiple-comments-demo-from-master

Owner

mokagio commented Feb 7, 2020

Same as #3, but with Danger JS fetched from master, which currently is at https://github.com/danger/danger-js/tree/cc03f331af8ee3784f404cd48e9e9585db1be91a.

mokagio added 2 commits

February 7, 2020 20:51


          Setup Danger JS & GitHub workflow to run it

751d67c


          Fetch Danger JS from master to see if the issue from #3 is fixed

caef58e

mokagio force-pushed the danger-multiple-comments-demo-from-master branch from b6e48fc to caef58e Compare

February 7, 2020 10:32

Owner Author

mokagio commented Feb 7, 2020

For some reason, when I install Danger JS via Yarn pointing it at the GitHub repo, it can't find the executable, neither on my machine nor [on CI](https://github.com/mokagio/danger-new-comments-example/pull/4/checks?check_run_id=431609947#step:6:8.

$ yarn run danger
yarn run v1.22.0
warning package.json: No license field
error Command "danger" not found.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

mokagio mentioned this pull request

Is Danger always making a new comment? danger/danger-js#856

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet