Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support key specific rules. #19

Merged
merged 1 commit into from
Sep 1, 2018

Conversation

ls-cyril-grosset
Copy link
Contributor

Hello, I would like to propose this change that allows the definition of rule set specific to one or more keys. This is helpful, if you want different quotas depending of the origin of the request for example.

@codecov
Copy link

codecov bot commented Jun 18, 2018

Codecov Report

Merging #19 into master will increase coverage by 2.79%.
The diff coverage is 89.36%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #19      +/-   ##
============================================
+ Coverage     63.33%   66.12%   +2.79%     
- Complexity      100      116      +16     
============================================
  Files            16       19       +3     
  Lines           330      369      +39     
  Branches         29       35       +6     
============================================
+ Hits            209      244      +35     
- Misses          114      115       +1     
- Partials          7       10       +3
Impacted Files Coverage Δ Complexity Δ
...ore/limiter/request/RequestLimitRulesSupplier.java 100% <100%> (ø) 8 <8> (?)
...iter/request/DefaultRequestLimitRulesSupplier.java 100% <100%> (ø) 3 <3> (?)
.../request/RedisSlidingWindowRequestRateLimiter.java 91.11% <100%> (-0.2%) 27 <0> (-1)
...elimitj/core/limiter/request/RequestLimitRule.java 73.52% <76.92%> (+0.45%) 16 <8> (+4) ⬆️
...s/request/SerializedRequestLimitRulesSupplier.java 83.33% <83.33%> (ø) 2 <2> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c25c8eb...d10f340. Read the comment docs.

@mokies
Copy link
Owner

mokies commented Aug 31, 2018

Thanks for the PR @cyril-grosset. I think this is a valuable addition and will attempt to merge

@mokies mokies merged commit d10f340 into mokies:master Sep 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants