Merge pull request #53 from mokshaproject/version-comparison

STOMP-1.2 can NACK, of course.
mokshaproject · Mar 9, 2018 · d640a7c · d640a7c
2 parents 1c2c923 + def7242
commit d640a7c
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/moksha.hub/moksha/hub/stomp/protocol.py b/moksha.hub/moksha/hub/stomp/protocol.py
@@ -21,6 +21,8 @@
 
 import logging
 
+from distutils.version import LooseVersion
+
 from moksha.common.lib.converters import asbool
 
 try:
@@ -136,7 +138,7 @@ def dataReceived(self, data):
                    # Return, so as not to send an erroneous ack.
                    return
 
-               if stomper.STOMP_VERSION != '1.1':
+               if LooseVersion(stomper.STOMP_VERSION) < LooseVersion('1.1'):
                    log.error("Unable to NACK stomp %r" % stomper.STOMP_VERSION)
                    # Also, not sending an erroneous ack.
                    return