Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NATS JetStream] allow to sub with wildcard #57

Merged
merged 2 commits into from
Jan 5, 2023
Merged

[NATS JetStream] allow to sub with wildcard #57

merged 2 commits into from
Jan 5, 2023

Conversation

AndreMaz
Copy link
Member

@AndreMaz AndreMaz commented Jan 4, 2023

Fixes #56

@AndreMaz AndreMaz requested a review from icebob January 4, 2023 16:40
@AndreMaz AndreMaz mentioned this pull request Jan 4, 2023
Closed
4 tasks
icebob
icebob approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job, thanks! Should we need to add info about it to the docs?

@AndreMaz
Copy link
Member Author

AndreMaz commented Jan 5, 2023

Yep, forgot about that. I added a small ref that points the actual example.

@icebob icebob merged commit 0b07ecf into master Jan 5, 2023
@icebob icebob deleted the feature/issue-56 branch January 5, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icebob icebob icebob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The NATS Channel adapter breaks when using wildcard topics
2 participants
@AndreMaz @icebob