fix: count just the right number of row

[DenisFerrero]

Apply a more explicit count of data for the pagination, normally there's no problem but when doing an include in the default scope will be counted the included data for each record. For example:

By having those two models

let User = sequelize.define("users",
    {
      id: { type: DataTypes.INTEGER, autoIncrement: true, primaryKey: true },
      username: { type: DataTypes.STRING }
    }, { paranoid: true }
);

let Auth = sequelize.define("auths",
    {
      id: { type: DataTypes.INTEGER, autoIncrement: true, primaryKey: true },
      name: { type: DataTypes.STRING }
    }, { paranoid: false }
);

and they have a relation like this

Auth.belongsTo(models["users"], {
  foreignKey: "user_id",
  as: "users"
});

When trying to get all users with this defaultScope

User.associate = function (models) {
    User.addScope("defaultScope", {
      include: [{
        model: models["auths"],
        as: "auths"
      }]
    });
};

The count value is equal to the number of auths that are related to each user returned.

See this SandBox for a working sample.

Fix for #302

[icebob]

Great, thanks. Please add relevant tests as well.

[DenisFerrero]

I'm not really into tests but I did my best to understand how to do that. Is it okay or do I need to explicit something else?

[icebob]

Thanks, it works with older sequelize versions, as well?

[DenisFerrero]

Don't tested, but I found from the Sequelize docs that the feature that I have applied ({ distinct: true, col: colName }) is available since Sequelize v3. Below the links to the docs of each version:

• Version 6
• Version 5
• Version 4
• Version 3

They wrote that if an include is provided this logic for filter the PK should be automatically applied but I think they didn't have tested using a defaulScope yet

[icebob]

Thank for your investigation.