Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return async expect statement #393

Merged

Conversation

shawnlauzon
Copy link
Contributor

@shawnlauzon shawnlauzon commented Oct 13, 2018

Because expect().resolves() returns a Promise, tests will always pass unless the result is
returned. The snippet here doesn't include the return call.

📝 Description

🎯 Relevant issues

Fixes #392

💎 Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

📜 Example code

🚦 How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • npm run test
  • Test B

🏁 Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

Because expect().resolves() returns a Promise, tests will always pass unless the result is
returned. The snippet here doesn't include the return call.
@coveralls
Copy link

coveralls commented Oct 13, 2018

Pull Request Test Coverage Report for Build 1500

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 91.998%

Totals Coverage Status
Change from base Build 1498: 0.01%
Covered Lines: 4631
Relevant Lines: 4812

💛 - Coveralls

Copy link
Member

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@icebob icebob merged commit bd1ac26 into moleculerjs:master Oct 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default unit test passes even when test fails
3 participants