use-hash-location subscribes to hashchange once
#381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To fix tearing issue when `hashchange` is fired asynchronously.
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
|
molefrog
changed the title
use-hash-location subscribes to hashchange only onceuse-hash-location subscribes to hashchange once
size-limit report 📦
|
jeetiss
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix tearing issue when
hashchangeis fired asynchronously.See this discussion whatwg/html#1792
TLDR; React schedules micro-task in between calls to
hashchangeevent listeners, because in some browsers this event is fired asynchronously (e.g. WebKit does it). This results in teared state when some components receive updates faster than others and it happens within one micro-task.