Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update docs uses armadillo 2 login block (R) style #633

Closed
erikzwart opened this issue Feb 7, 2024 · 2 comments
Closed

update docs uses armadillo 2 login block (R) style #633

erikzwart opened this issue Feb 7, 2024 · 2 comments
Assignees
@clemens-tolboom
Labels
documentation 📃 Improvements or additions to documentation
Milestone
Sprint 217

Comments

@erikzwart
Copy link
Collaborator

The R script examples in the docs contain the old style of login, is the rest of the script still valid using Armadillo 3/4?

molgenis-service-armadillo/docs/DataSHIELD-datamanagement/1_MolgenisArmadillo.r

Line 21 in 7689be3

minio = "https://armadillo-minio.test.molgenis.org"

@erikzwart erikzwart added the documentation 📃 Improvements or additions to documentation label Feb 7, 2024
@clemens-tolboom
Copy link
Collaborator

I think there are no links to this sub dir from https://molgenis.github.io/molgenis-service-armadillo/ ... did not search hard yet.

I think we could cleanup these?

@clemens-tolboom clemens-tolboom added this to the Sprint 217 milestone Feb 13, 2024
@clemens-tolboom clemens-tolboom self-assigned this Feb 19, 2024
clemens-tolboom added a commit that referenced this issue Feb 19, 2024
@clemens-tolboom
fix(docs): fixes #632,#633 remove refs to minio and up version
4a0ba8e
@clemens-tolboom
Copy link
Collaborator

Closing as will be fixed by PR #641

@clemens-tolboom clemens-tolboom mentioned this issue Feb 19, 2024
Open
1 task
clemens-tolboom added a commit that referenced this issue Feb 19, 2024
@clemens-tolboom
fix(docs): fixes #632,#633 remove refs to minio and up version
89b7622
clemens-tolboom added a commit that referenced this issue Feb 19, 2024
@clemens-tolboom
fix(docs): fixes #632,#633 remove refs to minio and up version (#641)
b19a875 
* fix(docs): fixes #632,#633 remove refs to minio and up version

* Update 2_Creating_data_subsets_Armadillo.r

Replace the last minio link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clemens-tolboom clemens-tolboom

Labels
documentation 📃 Improvements or additions to documentation
Projects
None yet
Milestone
Sprint 217
Development

No branches or pull requests
2 participants
@clemens-tolboom @erikzwart