Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #6492 EMX importer fails on BOM preventing CSV's to be uploaded in some cases #6520

Merged
merged 4 commits into from Aug 18, 2017
Merged

Fix #6492 EMX importer fails on BOM preventing CSV's to be uploaded in some cases #6520

merged 4 commits into from Aug 18, 2017

Conversation

sidohaakma
Copy link
Collaborator

@sidohaakma sidohaakma commented Aug 16, 2017 •
edited by bartcharbon

Checklist

  • Functionality works & meets specifications
  • Code reviewed
  • Code unit/integration/system tested
  • User documentation updated
  • (If you have changed REST API interface) view-swagger.ftl updated
  • Test plan template updated
  • Clean commits

@tommydeboer tommydeboer changed the title Fix/6492 Fix #6492 EMX importer fails on BOM preventing CSV's to be uploaded in some cases Aug 16, 2017
@tommydeboer tommydeboer self-assigned this Aug 16, 2017
@tommydeboer tommydeboer self-requested a review August 16, 2017 10:32
@tommydeboer
Copy link
Collaborator

tommydeboer commented Aug 16, 2017 •
edited

When importing the attached zip file in #6492 I get a (different) error:

Unsupported attribute metadata: attributes.e

@tommydeboer
Copy link
Collaborator

Can you add a unit test for this edge case?

tommydeboer
tommydeboer requested changes Aug 16, 2017
View reviewed changes
Copy link
Collaborator

@tommydeboer tommydeboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing unit test and error on import

@bartcharbon bartcharbon changed the base branch from master to 5.1 August 18, 2017 06:49
@bartcharbon bartcharbon merged commit edd6e44 into molgenis:5.1 Aug 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommydeboer tommydeboer tommydeboer requested changes

@bartcharbon bartcharbon bartcharbon approved these changes

Assignees

@sidohaakma sidohaakma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sidohaakma @tommydeboer @bartcharbon