Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M6440 Files API doc update & small enhancements #8290

Merged
merged 4 commits into from
Mar 26, 2019
Merged

M6440 Files API doc update & small enhancements #8290

merged 4 commits into from
Mar 26, 2019

Conversation

dennishendriksen
Copy link
Contributor

@dennishendriksen dennishendriksen commented Mar 22, 2019

  • Add properties to documentation
  • Replace 200 with 204 response code for delete endpoint
  • Perform security checks as soon as possible

Checklist

  • Functionality works & meets specifications
  • Code reviewed
  • Code unit/integration/system tested
  • User documentation updated
  • (If you have changed REST API interface) view-swagger.ftl updated
  • Test plan template updated
  • Clean commits
  • Added Feature/Fix to release notes

@codecov
Copy link

codecov bot commented Mar 22, 2019

Codecov Report

Merging #8290 into master will increase coverage by <.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             master   #8290     +/-   ##
==========================================
+ Coverage        62%     62%   +<.1%     
- Complexity     7663    7668      +5     
==========================================
  Files          1228    1228             
  Lines         36819   36835     +16     
  Branches       3679    3680      +1     
==========================================
+ Hits          22846   22863     +17     
+ Misses        12357   12355      -2     
- Partials       1616    1617      +1
Flag Coverage Δ Complexity Δ
#api ? ?
#integration 7.6% <ø> (ø) 3 <ø> (ø) ⬇️
#unit 62.1% <100%> (ø) 7665 <9> (+5) ⬆️
Impacted Files Coverage Δ Complexity Δ
...ava/org/molgenis/api/files/v1/FilesController.java 100% <100%> (+6.8%) 14 <9> (+6) ⬆️
...ain/java/org/molgenis/data/importer/ImportRun.java 84.4% <0%> (-2.3%) 22% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ddc6e2...df12997. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 22, 2019

Codecov Report

Merging #8290 into master will increase coverage by <.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             master   #8290     +/-   ##
==========================================
+ Coverage        62%     62%   +<.1%     
- Complexity     7663    7668      +5     
==========================================
  Files          1228    1228             
  Lines         36819   36835     +16     
  Branches       3679    3680      +1     
==========================================
+ Hits          22846   22863     +17     
+ Misses        12357   12355      -2     
- Partials       1616    1617      +1
Flag Coverage Δ Complexity Δ
#api ? ?
#integration 7.6% <ø> (ø) 3 <ø> (ø) ⬇️
#unit 62.1% <100%> (ø) 7665 <9> (+5) ⬆️
Impacted Files Coverage Δ Complexity Δ
...ava/org/molgenis/api/files/v1/FilesController.java 100% <100%> (+6.8%) 14 <9> (+6) ⬆️
...ain/java/org/molgenis/data/importer/ImportRun.java 84.4% <0%> (-2.3%) 22% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ddc6e2...6bd11ba. Read the comment docs.

@bartcharbon bartcharbon self-assigned this Mar 26, 2019
@bartcharbon bartcharbon self-requested a review March 26, 2019 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants