Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonar and swagger improvements for permissions API #8524

Merged
merged 3 commits into from Jun 3, 2019

Conversation

bartcharbon
Copy link
Member

@bartcharbon bartcharbon commented May 27, 2019

Checklist

  • Functionality works & meets specifications
  • Code reviewed
  • [n.a.] Code unit/integration/system tested
  • [n.a.] Migration step added in case of breaking change
  • [n.a.] User documentation updated
  • [n.a.] (If you have changed REST API interface) view-swagger.ftl updated
  • [n.a.] Test plan template updated
  • Clean commits
  • [n.a.] Added Feature/Fix to release notes

@codecov
Copy link

codecov bot commented May 27, 2019

Codecov Report

Merging #8524 into master will increase coverage by <.1%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             master   #8524     +/-   ##
==========================================
+ Coverage      62.3%   62.4%   +<.1%     
+ Complexity     8129    8122      -7     
==========================================
  Files          1319    1316      -3     
  Lines         38493   38639    +146     
  Branches       3865    3865             
==========================================
+ Hits          24000   24119    +119     
- Misses        12802   12830     +28     
+ Partials       1691    1690      -1
Flag Coverage Δ Complexity Δ
#api 100% <ø> (ø) 0 <ø> (ø) ⬇️
#integration 7.6% <ø> (ø) 3 <ø> (ø) ⬇️
#unit 62.4% <0%> (ø) 8119 <0> (-7) ⬇️
Impacted Files Coverage Δ Complexity Δ
...exceptions/rsql/PermissionQueryParseException.java 100% <ø> (ø) 2 <0> (ø) ⬇️
.../security/exception/AclAlreadyExistsException.java 100% <ø> (ø) 3 <0> (ø) ⬇️
...rity/exception/AclClassAlreadyExistsException.java 100% <ø> (ø) 3 <0> (ø) ⬇️
...l/UnsupportedPermissionQueryOperatorException.java 100% <ø> (ø) 2 <0> (ø) ⬇️
...ons/rsql/UnknownPermissionQueryParamException.java 100% <ø> (ø) 3 <0> (ø) ⬇️
...olgenis/api/permissions/PermissionsController.java 86.3% <0%> (-0.2%) 40 <0> (ø)
...is/semanticmapper/mapping/model/MappingTarget.java 51.7% <0%> (-1.9%) 16% <0%> (ø)
...ta/migrate/version/MolgenisUpgradeServiceImpl.java 40% <0%> (-1.4%) 4% <0%> (ø)
...is/semanticmapper/mapping/model/EntityMapping.java 51.2% <0%> (-1.4%) 19% <0%> (ø)
...is/genomebrowser/service/GenomeBrowserService.java 63% <0%> (-0.9%) 21% <0%> (ø)
... and 92 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3956ec5...07a754e. Read the comment docs.

@dennishendriksen dennishendriksen merged commit 13ff009 into molgenis:master Jun 3, 2019
@bartcharbon bartcharbon deleted the sonar/permissions branch August 27, 2019 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants