Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap dependencies in namespace #819

Closed
tombroucke opened this issue Aug 14, 2023 · 4 comments
Closed

Wrap dependencies in namespace #819

tombroucke opened this issue Aug 14, 2023 · 4 comments

Comments

@tombroucke
Copy link

Hi,

We have multiple e-commerce stores running on roots/sage and use this plugin for payments.
Since 7.3.8, this plugin is triggering a fatal error. We had to lock this plugin on all websites to v7.3.7.

Fatal error: Declaration of Illuminate\Container\Container::get(string $id) must be compatible with Psr\Container\ContainerInterface::get($id) in /Users/tombroucke/Local/examplecom/app/vendor/illuminate/container/Container.php on line 714

roots/sage depends on roots/acorn, which requires psr/container ^2.0.

Could you please wrap your dependencies in your own namespace as described on the compatibility page?

I have already opened a support ticket on your WordPress support page some weeks ago, but wanted to add this issue to the issue tracker.

Kind regards,
Tom

@sebastian-mollie
Copy link

@tombroucke thanks for the report, we are looking into this. Most probably will have a fix for the next release in the coming weeks.

@InpsydeNiklas
Copy link
Collaborator

Hi @tombroucke, thanks for raising the issue and your patience!
Could you please give it a try with the 7.4.0 pre-release and let us know how this works for you? Thank you!

@tombroucke
Copy link
Author

Hi, Thank you for your follow-up.
This issue is resolved in the 7.4.0 pre-release. I haven't tested this thoroughly for other issues.

I am getting a warning however, but if I call correctly, it has always been there.
The warning is triggered because you are trying to log an array in mollie-payments-for-woocommerce/src/Payment/PaymentService.php:486. But this isn't part of this issue.

@InpsydeNiklas
Copy link
Collaborator

The dependency conflict was resolved in 7.4.0. If any troubles remain, I suggest contacting the Mollie support directly for additional guidance. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants