Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor KTfwd::traits #46

Closed
molpopgen opened this issue Feb 26, 2017 · 1 comment
Closed

Refactor KTfwd::traits #46

molpopgen opened this issue Feb 26, 2017 · 1 comment
Assignees
@molpopgen
Labels
API enhancement

Comments

@molpopgen
Copy link
Owner

molpopgen commented Feb 26, 2017 •
edited
Loading

Issues #45 brings up some aesthetic issues with how type traits are implemented. They should be cleaned up and cues taken from the C++17 additions to the standard library's type traits. This basically involves some renaming and adding template aliases for convenience.

In addressing the issue described above, I discovered that a lot of the type traits fail to do their job. Many will fail to compile when provided "bad" or incorrect types rather than have SFINAE result in a static type that can be evaluated. This issue is turning into a "refactor the type traits part of fwdpp".
@molpopgen molpopgen self-assigned this Feb 26, 2017
molpopgen added a commit that referenced this issue Feb 27, 2017
@molpopgen
first steps towards #46
4c0e9ef
molpopgen added a commit that referenced this issue Feb 27, 2017
@molpopgen
refactor type traits for diploids. #46
2e0db3b
molpopgen added a commit that referenced this issue Feb 27, 2017
@molpopgen
make more type trait names consistent. #46
7e7c477
molpopgen added a commit that referenced this issue Feb 27, 2017
@molpopgen
reorganize type traits headers a bit. add is_multilocus_diploid type …
6a17dec 
…trait. #45, #46
molpopgen added a commit that referenced this issue Feb 27, 2017
@molpopgen
further reorg of type trait headers. Added SFINAE deduction of fitnes…
ccd40c3 
…s model type. Will eval to void if argument types are incorrect. #46
molpopgen added a commit that referenced this issue Feb 27, 2017
@molpopgen
add unit test of traits::fitness_fxn. #46
7d8db44
molpopgen added a commit that referenced this issue Feb 27, 2017
@molpopgen
more dox. #46
c2b72a5
molpopgen added a commit that referenced this issue Feb 28, 2017
@molpopgen
add fwdpp/internal/void_t.hpp #46
e58a4be
molpopgen added a commit that referenced this issue Feb 28, 2017
@molpopgen
add internal/void_t.hpp to build system. #46
7a63660
molpopgen added a commit that referenced this issue Feb 28, 2017
@molpopgen
simplify static assertion. #46
d41ddf7
molpopgen added a commit that referenced this issue Feb 28, 2017
@molpopgen
added is_fitness_fxn. #46
ac5f858
molpopgen added a commit that referenced this issue Feb 28, 2017
@molpopgen
simplify implementation of is_fitness_fxn with a default typename #46.
47ce773
molpopgen added a commit that referenced this issue Feb 28, 2017
@molpopgen
hide implementation details of traits::is_fitness_fxn. #46
2e53cfe
molpopgen added a commit that referenced this issue Feb 28, 2017
@molpopgen
clean up implementation of is_fitness_fxn. #46
ba9bf81
molpopgen added a commit that referenced this issue Feb 28, 2017
@molpopgen
document traits::is_fitness_fxn. #46
6902273
molpopgen added a commit that referenced this issue Feb 28, 2017
@molpopgen
is_rec_model is now a proper type trait. #46
d5ba304
molpopgen added a commit that referenced this issue Feb 28, 2017
@molpopgen
mmodel_t and mmodel_gamete_t are now nice SFINAE types. #46
10bddba
molpopgen added a commit that referenced this issue Feb 28, 2017
@molpopgen
traits::recmodel_t refactored. #46
076a184
molpopgen added a commit that referenced this issue Feb 28, 2017
@molpopgen
reorder headers a bit and document how SFINAE scheme works. #46
576def3
molpopgen added a commit that referenced this issue Feb 28, 2017
@molpopgen
refactored fwdpp_internal::recycling_bin_t. #46
4feb865
molpopgen added a commit that referenced this issue Feb 28, 2017
@molpopgen
more convenience templates. #46
9cc55b7
molpopgen added a commit that referenced this issue Mar 1, 2017
@molpopgen
documentation for type traits. #46
2d35de8
@molpopgen
Copy link
Owner Author

Done in 0.5.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@molpopgen molpopgen

Labels
API enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@molpopgen