Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demes graphs with end times > 0 #1253

Closed
molpopgen opened this issue Dec 12, 2023 · 0 comments
Closed

Demes graphs with end times > 0 #1253

molpopgen opened this issue Dec 12, 2023 · 0 comments
Labels
Milestone

Comments

@molpopgen
Copy link
Owner

When a graph has its minimal end_time > 0, export to tskit will
still shift all node times such that they are 0.0 in that format.

This behavior is not great and can complicate some downstream work.

The export function already takes an optional demes graph as input.
We should check if it is not None, check the minimal end time,
and use that value as an offset for all exported node times.

cc @apragsdale

@molpopgen molpopgen added this to the 0.22.0 milestone Dec 12, 2023
molpopgen added a commit that referenced this issue Jan 18, 2024
sequence that has alive node times all > 0.0.

* manual: remove documentation on allowing > 1 ModelParams exported to
tskit.
* remove test of multiple modelparam export

See #1257 and #1256

Fixes #1253
molpopgen added a commit that referenced this issue Jan 18, 2024
sequence that has alive node times all > 0.0.

* manual: remove documentation on allowing > 1 ModelParams exported to
tskit.
* remove test of multiple modelparam export

See #1257 and #1256

Fixes #1253
molpopgen added a commit that referenced this issue Jan 19, 2024
sequence that has alive node times all > 0.0.

* manual: remove documentation on allowing > 1 ModelParams exported to
tskit.
* remove test of multiple modelparam export

See #1257 and #1256

Fixes #1253
molpopgen added a commit that referenced this issue Jan 19, 2024
end at times > 0. (#1255)

* manual: remove documentation on allowing > 1 ModelParams exported to
tskit.
* remove test of multiple modelparam export

See #1257 and #1256

Fixes #1253
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant