Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate dict as valid type for model_params when exporting to tskit #1256

Closed
molpopgen opened this issue Dec 14, 2023 · 2 comments
Closed

Deprecate dict as valid type for model_params when exporting to tskit #1256

molpopgen opened this issue Dec 14, 2023 · 2 comments
Milestone
0.22.0

Comments

@molpopgen
Copy link
Owner

There is no good reason not to use the ModelParams instance itself.
@molpopgen molpopgen added this to the 0.22.0 milestone Dec 14, 2023
@molpopgen
Copy link
Owner Author

Implementing this implies breaking a test where multiple parameters instances are passed in a dict for export. Such models complicate metadata and are messy to specify in the first place. We should instead allow parameters of the genetics to change in a way that is specified in a single ModelParams instance.

@molpopgen
Copy link
Owner Author

We likely also have to change the TopLevelMetadata schema

molpopgen added a commit that referenced this issue Jan 18, 2024
@molpopgen
Fix behavior of building DiploidPopulation from a tree
258e9b5 
sequence that has alive node times all > 0.0.

* manual: remove documentation on allowing > 1 ModelParams exported to
tskit.
* remove test of multiple modelparam export

See #1257 and #1256

Fixes #1253
molpopgen added a commit that referenced this issue Jan 18, 2024
@molpopgen
Fix behavior of building DiploidPopulation from a tree
9a2f35c 
sequence that has alive node times all > 0.0.

* manual: remove documentation on allowing > 1 ModelParams exported to
tskit.
* remove test of multiple modelparam export

See #1257 and #1256

Fixes #1253
molpopgen added a commit that referenced this issue Jan 19, 2024
@molpopgen
Fix behavior of building DiploidPopulation from a tree (#1255)
5983801 
sequence that has alive node times all > 0.0.

* manual: remove documentation on allowing > 1 ModelParams exported to
tskit.
* remove test of multiple modelparam export

See #1257 and #1256

Fixes #1253
molpopgen added a commit that referenced this issue Jan 19, 2024
@molpopgen
Fix exporting to tskit.TreeSeuqence when demographic models
ae904d0 
end at times > 0. (#1255)

* manual: remove documentation on allowing > 1 ModelParams exported to
tskit.
* remove test of multiple modelparam export

See #1257 and #1256

Fixes #1253
molpopgen added a commit that referenced this issue Jan 19, 2024
@molpopgen
Fix exporting to tskit.TreeSequence when demographic models
d2dc10a 
end at times > 0. (#1255)

* manual: remove documentation on allowing > 1 ModelParams exported to
tskit.
* remove test of multiple modelparam export

See #1257 and #1256

Fixes #1253
molpopgen added a commit that referenced this issue Jan 19, 2024
@molpopgen
Deprecate some options for exporting to tskit.
03b12be 
Closes #1256
Closes #1257
@molpopgen molpopgen mentioned this issue Jan 19, 2024
Merged
molpopgen added a commit that referenced this issue Jan 19, 2024
@molpopgen
Deprecate some options for exporting to tskit.
e054f3f 
* remove test of deprecated features

Closes #1256
Closes #1257
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.22.0
Development

No branches or pull requests
1 participant
@molpopgen