Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote the internal state of a discrete demographic model to a fully-functional class. #783

Closed
molpopgen opened this issue Jun 19, 2021 · 1 comment · Fixed by #791
Closed

Promote the internal state of a discrete demographic model to a fully-functional class. #783

molpopgen opened this issue Jun 19, 2021 · 1 comment · Fixed by #791
Labels
C++ back end
Projects
Streamline discrete demography code
Milestone
0.16.0

Comments

@molpopgen
Copy link
Owner

Currently, this class is tightly-coupled to the implementation details of DiscreteDemography. This coupling is bad design and happened "organically".

This class should be able to fully contain the entire current state of the model. Thus, it should contain copies of the events in the DiscreteDemography class and manage the "event ranges".

This class should also be able to "reset" itself, and spawn an "unevolved" copy (e.g., ready to go from time zero again). Given a set of initial deme sizes, it would also be handy to be able to set the state to start at an arbitrary time.
@molpopgen molpopgen created this issue from a note in Streamline discrete demography code (To do) Jun 19, 2021
@molpopgen molpopgen added this to the 0.16.0 milestone Jun 19, 2021
@molpopgen molpopgen linked a pull request Jun 20, 2021 that will close this issue
Refactor demographic model internal state #786
Closed
@molpopgen molpopgen linked a pull request Jul 19, 2021 that will close this issue
Make demographic model state standalone #791
Merged
molpopgen added a commit that referenced this issue Jul 19, 2021
@molpopgen
Refactor the class handling the state of a discrete demographic model.
5b313b6 
The new class is completely independent of DiscreteDemography.

Closes #782
Closes #783

This PR also affects the implementation of changes made in
PRs #773 and #774
@molpopgen
Copy link
Owner Author

Given a set of initial deme sizes, it would also be handy to be able to set the state to start at an arbitrary time.

This is not handled by #791. This should be a separate action item.

Streamline discrete demography code automation moved this from To do to Done Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C++ back end
Projects
No open projects
Streamline discrete demography code
  
Done
Milestone
0.16.0
1 participant
@molpopgen