Add tests of evolving demes models in multiple stages #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is revealing a rare/subtle/corner case bug: if we leave a model at a time when a deme will go extinct, the next deme sizes are off if we re-enter the simulation. By changing the second |
population splits. * When a migration lookup table is NULL, the exception now reports the offspring deme index. * Keep track of whether demographic_model_state pointer was null at start of simulation. If not, then we do NOT call the "model updating" code path prior to entering the main loop. Fixes #775 Causes #777
molpopgen
force-pushed
the
add_tests_of_evolving_demes_models_in_multiple_stages
branch
from
70f76b2
to
6221ba2
Compare
molpopgen
deleted the
add_tests_of_evolving_demes_models_in_multiple_stages
branch
molpopgen
added a commit
that referenced
this pull request
Jul 5, 2021
…ation splits. (#774) * When a migration lookup table is NULL, the exception now reports the offspring deme index. * Keep track of whether demographic_model_state pointer was null at start of simulation. If not, then we do NOT call the "model updating" code path prior to entering the main loop. Fixes #775 Causes #777
molpopgen
added a commit
that referenced
this pull request
Jul 19, 2021
molpopgen
added a commit
that referenced
this pull request
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.