Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in initializing founder genome count. #836

Closed
molpopgen opened this issue Oct 26, 2021 · 0 comments
Closed

Bug in initializing founder genome count. #836

molpopgen opened this issue Oct 26, 2021 · 0 comments
Labels

Comments

@molpopgen
Copy link
Owner

molpopgen commented Oct 26, 2021

When a DiploidPopulation is constructed, it is passing N to the base class. This base class knows nothing about ploidy, resulting in the founder genome having a count of N and not 2N. This was discovered quite indirectly when working on #828 and was only possible to catch due to molpopgen/fwdpp#353

While working on #828, unexpected runtime errors were getting raised. I've tracked it down to the add mutation function, but the exact cause is not known. The symptom is that a diploid can end up referring to an extinct genome.

@molpopgen molpopgen added the bug label Oct 26, 2021
@molpopgen molpopgen changed the title Bug in fwdpy11.add_mutation Bug in DiploidPopulation.add_mutation Oct 26, 2021
molpopgen added a commit that referenced this issue Oct 27, 2021
@molpopgen molpopgen changed the title Bug in DiploidPopulation.add_mutation Bug in initializing founder genome count. Oct 27, 2021
molpopgen added a commit that referenced this issue Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant