Add copy/deepcopy semantics for DiploidPopulation #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molpopgen
added a commit
that referenced
this pull request
Jul 5, 2021
* Add copy/deepcopy to DiploidPopulation * Update DiploidPopulation docstring. * Update change log (and fix missing link to #764).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A naive copy.copy/deepcopy does not do the right thing. This PR adds the magic functions to both base and sub classes. Only the deep copy function does a deep copy of the table. The copy function simply copies the underlying shared_ptr.