Remove build dependency on .NET 3.5 tools #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminates a lingering build dependency on an ancient version of Microsoft.Build.Utilities (v2.0.0.0), which won't be available in environments where .NET Framework 3.5 build tools have not been installed [^1] See https://www.nuget.org/packages/UnmanagedExports.Repack.Upgrade Caveats ........ * initial builds must now run a 'Restore' task first [^2] * this adds package references with the 'GeneratePathProperty' attribute, so at least VS 2019 (i.e. MSBuild 16), or NuGet 5.0, is required [^3] [^1] https://community.notepad-plus-plus.org/post/93058 [^2] https://learn.microsoft.com/nuget/reference/msbuild-targets#restore-target [^3] https://learn.microsoft.com/nuget/consume-packages/package-references-in-project-files#generatepathproperty
|
I'm inclined to use PR #4 instead. Could you test it out? |
I will next time I'm at a Windows box. Your $ git ls-files --eol | grep \.PNG
i/-text w/-text attr/text eol=crlf NppCSharpPluginPack/Resources/about form icon.PNG
i/-text w/-text attr/text eol=crlf NppCSharpPluginPack/Resources/about form toolbar darkmode.PNG
i/-text w/-text attr/text eol=crlf NppCSharpPluginPack/Resources/close html tag icon darkmode.PNG
i/-text w/-text attr/text eol=crlf NppCSharpPluginPack/Resources/close html tag icon.PNG
i/-text w/-text attr/text eol=crlf NppCSharpPluginPack/Resources/selection remembering form icon darkmode.PNG
i/-text w/-text attr/text eol=crlf NppCSharpPluginPack/Resources/selection remembering form icon.PNG
i/-text w/-text attr/text eol=crlf docs/about form.PNG
i/-text w/-text attr/text eol=crlf docs/all forms MossyLawn.PNG
i/-text w/-text attr/text eol=crlf docs/all forms dark mode.PNG
i/-text w/-text attr/text eol=crlf docs/all forms default style.PNG
i/-text w/-text attr/text eol=crlf docs/popup dialog.PNG
i/-text w/-text attr/text eol=crlf docs/selections remembering form.PNG
i/-text w/-text attr/text eol=crlf docs/settings form.PNGFor someone used to cross-platform .NET SDK projects, I've never had a situation where I could not even check out a branch, but here we are: A |
|
Superseded by #4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the community-reported issue at https://community.notepad-plus-plus.org/post/93058
Note that the package taking the place of Rob Giesecke's original UnmanagedExports is newish at best, judging by the project's amount of activity: https://github.com/stevenengland/UnmanagedExports.Repack.Upgrade
This one's transitive dependencies are pulled from NuGet, so your dev environment doesn't get polluted by vintage assemblies.