Rdipardo refactor/unmanaged exports #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminates a lingering build dependency on an ancient version of Microsoft.Build.Utilities (v2.0.0.0), which won't be available in environments where .NET Framework 3.5 build tools have not been installed [^1] See https://www.nuget.org/packages/UnmanagedExports.Repack.Upgrade Caveats ........ * initial builds must now run a 'Restore' task first [^2] * this adds package references with the 'GeneratePathProperty' attribute, so at least VS 2019 (i.e. MSBuild 16), or NuGet 5.0, is required [^3] [^1] https://community.notepad-plus-plus.org/post/93058 [^2] https://learn.microsoft.com/nuget/reference/msbuild-targets#restore-target [^3] https://learn.microsoft.com/nuget/consume-packages/package-references-in-project-files#generatepathproperty
rdipardo's initial commit broke the old behavior
of always creating a plugin dir in the correct place
and then copying the dll to the directory.
Unfortunately, I still can't copy testfiles to the plugin directory
because the RecursiveDir item is completely cursed
rdipardo
reviewed
Feb 27, 2024
Release version 0.0.3
This has been tested successfully on Notepad++ versions
7.3.3, 8.3.3, 8.5.5, 8.5.8, and 8.6.4
(both 32-bit and 64-bit versions of each.
Now the user can specify a non-ProgramFiles directory
to start from, using the command line. See Changelog.
|
Thanks for your help, @rdipardo ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporates @rdipardo's PR #3, but includes a commit to fix the old behavior of always creating the plugin directory in the Notepad++ folder, and then copying the dll to the plugin folder.
This will only work if you have a
ProgramFilesorProgramFiles (x86)Notepad++ installation. Maybe there's a better way to do this, like a batch or PowerShell script that is triggered in the csproj?When testing this PR, I recommend deleting the plugin folder in your Notepad++ installation before building, to verify that the plugin folder is created.