Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a version const (or at least a comment) #747

Closed
networkimprov opened this issue Jul 26, 2020 · 1 comment · Fixed by #794
Closed

Add a version const (or at least a comment) #747

networkimprov opened this issue Jul 26, 2020 · 1 comment · Fixed by #794
Labels
issue: enhancement

Comments

@networkimprov
Copy link

We can't tell the version of Luxon by reading an API constant, or even looking at the source. This is common practice in Javascript libraries.

Thanks!
@GillesDebunne
Copy link
Collaborator

This is indeed a good idea. Thanks

pgcalixto added a commit to pgcalixto/luxon that referenced this issue Oct 3, 2020
@pgcalixto
Export VERSION information
972e157 
As pointed out by @networkimprov, it is a good practice to tell the
package version by exporting a constant or having a comment to
indicate it. Therefere, the version info is exported now.

Resolves moment#747.
@pgcalixto pgcalixto mentioned this issue Oct 3, 2020
Merged
pgcalixto added a commit to pgcalixto/luxon that referenced this issue Oct 8, 2020
@pgcalixto
Export hardcoded VERSION variable
ffd2952 
For a less bold approach, the exported VERSION variable is now
hardcoded. Meanwhile, the `scripts/tag` script was improved to
ensure that all versions match.

See moment#800 (comment).

Resolves moment#747 and moment#799.
pgcalixto added a commit to pgcalixto/luxon that referenced this issue Oct 8, 2020
@pgcalixto
Export hardcoded VERSION variable
2a14727 
For a less bold approach, the exported VERSION variable is now
hardcoded. Meanwhile, the `scripts/tag` script was improved to
ensure that all versions match.

See moment#800 (comment).

Resolves moment#747 and resolves moment#799.
icambron pushed a commit that referenced this issue Nov 9, 2020
@pgcalixto
Export VERSION information (#794)
343978d 
* Export VERSION information

As pointed out by @networkimprov, it is a good practice to tell the
package version by exporting a constant or having a comment to
indicate it. Therefere, the version info is exported now.

Resolves #747.

* Revert "Export VERSION information"

This reverts commit 972e157.

@GillesDebunne and I agreed on a different approach, which is based
on a hardcoded VERSION export, while maintaining a logic to ensure
that the VERSION variable matches the package version.

See #800 (comment).

* Export hardcoded VERSION variable

For a less bold approach, the exported VERSION variable is now
hardcoded. Meanwhile, the `scripts/tag` script was improved to
ensure that all versions match.

See #800 (comment).

Resolves #747 and resolves #799.

* Move version validation to dedicated script

Move the version validation to a dedicated script, so that it can
be called both from release and tag scripts, which are scripts that
should validate the version before proceeding.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Export VERSION information pgcalixto/luxon
2 participants
@networkimprov @GillesDebunne