-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version with npm script #800
Bump version with npm script #800
Conversation
The npm `version` script bumps the version on both package.json and package-lock.json, which are currently not matching. Also, it creates a new bump commit and tags it.
Changed it to draft since it is more of a suggestion up for discussion than a PR ready to merge. |
I believe the bump version process is manual. It requires writing a summarized changelog, as well as deciding between a minor and a patch release, and updating I think
What do you think? |
I agree with the hardcoded The approach you suggested makes total sense. I will try to develop this approach in the other PR (#794), then I'll close this one. |
This reverts commit 972e157. @GillesDebunne and I agreed on a different approach, which is based on a hardcoded VERSION export, while maintaining a logic to ensure that the VERSION variable matches the package version. See moment#800 (comment).
For a less bold approach, the exported VERSION variable is now hardcoded. Meanwhile, the `scripts/tag` script was improved to ensure that all versions match. See moment#800 (comment). Resolves moment#747 and moment#799.
For a less bold approach, the exported VERSION variable is now hardcoded. Meanwhile, the `scripts/tag` script was improved to ensure that all versions match. See moment#800 (comment). Resolves moment#747 and resolves moment#799.
Closing this as it is being reworked on #794. |
* Export VERSION information As pointed out by @networkimprov, it is a good practice to tell the package version by exporting a constant or having a comment to indicate it. Therefere, the version info is exported now. Resolves #747. * Revert "Export VERSION information" This reverts commit 972e157. @GillesDebunne and I agreed on a different approach, which is based on a hardcoded VERSION export, while maintaining a logic to ensure that the VERSION variable matches the package version. See #800 (comment). * Export hardcoded VERSION variable For a less bold approach, the exported VERSION variable is now hardcoded. Meanwhile, the `scripts/tag` script was improved to ensure that all versions match. See #800 (comment). Resolves #747 and resolves #799. * Move version validation to dedicated script Move the version validation to a dedicated script, so that it can be called both from release and tag scripts, which are scripts that should validate the version before proceeding.
This is a suggestion to resolve #799.
This is not necessarily intended to be merged. It was created mainly as a suggestion for further discussion and improvements.