Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure timezone abbreviations are in alphabets #302

Merged
merged 1 commit into from
Feb 23, 2016
Merged

Ensure timezone abbreviations are in alphabets #302

merged 1 commit into from
Feb 23, 2016

Conversation

beata
Copy link

@beata beata commented Feb 19, 2016

The timezone abbreviation(Taiwan or China) on "Chrome / Windows 7" isn't an alphabet string.

It returns something like this:

(new Date()).toTimeString()
=> '17:56:31 GMT+0800 (台北標準時間)'

I've changed the regular expression in OffsetAt to let abbr property from non-alphabet timezones as undefined

@timrwood
Copy link
Member

Nice, thanks for the contribution! Looks like this should help address #294.

timrwood added a commit that referenced this pull request Feb 23, 2016
Ensure timezone abbreviations are in alphabets
@timrwood timrwood merged commit 6979afa into moment:develop Feb 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants