Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Myanmar localization #1778

Merged
merged 1 commit into from
Jul 21, 2014
Merged

Myanmar localization #1778

merged 1 commit into from
Jul 21, 2014

Conversation

gholadr
Copy link
Contributor

@gholadr gholadr commented Jul 17, 2014

fixed formatting issues (jscs) as reported by Travis

@yelinaung
Copy link

LGTM but what happened to README O.o

@yelinaung
Copy link

Anyway, @thanyawzinmin, @saturngod, @trhura, @setkyar, can you guys take a look at the my.js ?

@gholadr
Copy link
Contributor Author

gholadr commented Jul 17, 2014

:-o
Good catch @yelinaung! - undeleted README.md

@talnetd
Copy link

talnetd commented Jul 17, 2014

What kind of Encoding you used there ? Can't read up correctly here !

@icambron
Copy link
Member

Do you mind squashing these commits down? Normally we don't mind a few commits in one PR, but that's a lot.

@ichernev
Copy link
Contributor

I guess the original plan was to keep the list of contributors .. but this has gone out of control :)

@setkyar
Copy link

setkyar commented Jul 18, 2014

Why is the nextWeek : 'dddd LT [မှာ]', ? It's not နောက်အပတ် ? @yelinaung @htlwin2006

@gholadr
Copy link
Contributor Author

gholadr commented Jul 18, 2014

@icambron - done, we've squashed the commits as requested.

@gholadr
Copy link
Contributor Author

gholadr commented Jul 21, 2014

@icambron - looks like we have consensus on our end and this PR is ready.

icambron added a commit that referenced this pull request Jul 21, 2014
@icambron icambron merged commit ef5f151 into moment:develop Jul 21, 2014
@icambron
Copy link
Member

Awesome, thanks everyone!

@gholadr
Copy link
Contributor Author

gholadr commented Jul 21, 2014

sweet! thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants