New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spm support #1647

Merged
merged 1 commit into from May 14, 2014

Conversation

Projects
None yet
2 participants
@afc163
Contributor

afc163 commented May 7, 2014

@ichernev

This comment has been minimized.

Contributor

ichernev commented May 7, 2014

Merged in #1646

@ichernev ichernev closed this May 7, 2014

@afc163

This comment has been minimized.

Contributor

afc163 commented May 8, 2014

#1646 has a wrong commit.

output: {
  "lang/ar-ma.js",
  "lang/ar.js",
  ...
}

should be

output: [
  "lang/ar-ma.js",
  "lang/ar.js",
  ...
]
@ichernev

This comment has been minimized.

Contributor

ichernev commented May 10, 2014

@afc163 all is good now, right?

@afc163

This comment has been minimized.

Contributor

afc163 commented May 11, 2014

Correct!

@afc163

This comment has been minimized.

Contributor

afc163 commented May 12, 2014

So, would this pull be merged?

@ichernev

This comment has been minimized.

Contributor

ichernev commented May 12, 2014

I'll fix it tomorrow.

@ichernev ichernev reopened this May 14, 2014

@ichernev

This comment has been minimized.

Contributor

ichernev commented May 14, 2014

Aaaah I got so confused. I though we merged the first one, but you actually closed it. So this one wasn't conflicting with the other one. I'm sorry for being so slow.

ichernev added a commit that referenced this pull request May 14, 2014

@ichernev ichernev merged commit 43f6e95 into moment:develop May 14, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@afc163

This comment has been minimized.

Contributor

afc163 commented May 14, 2014

😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment