New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locale Punjabi(Gurmukhi) India format conversion #2917

Closed
wants to merge 2 commits into
base: develop
from

Conversation

Projects
None yet
5 participants
@harpreetkhalsagtbit
Contributor

harpreetkhalsagtbit commented Jan 22, 2016

Locale Punjabi(Gurmukhi) India format conversion.

@mj1856 mj1856 added the Language label Feb 2, 2016

@mj1856

This comment has been minimized.

Member

mj1856 commented Feb 2, 2016

Thanks for your contribution! Here's what we look for with new locales:

  • Correct file placement and code structure.
  • Includes unit tests.
  • Correct language and country code.
  • We don't have this locale already.
  • Verification from another native speaker (if possible)

Please see if you can locate a colleague or other native speaker. We'd like to list at least two individuals per locale, who can respond to suggested changes as they may arise.

Thanks.

@harpreetkhalsagtbit

This comment has been minimized.

Contributor

harpreetkhalsagtbit commented Feb 5, 2016

@mj1856 Thanks for a reply.

Yes, sure, I can locate few native speakers. But what should I need to do? Do i need to send you their github profile or they should Review the PR and its locale content and comment as "passed/Reviewed/Fine" etc

@mj1856

This comment has been minimized.

Member

mj1856 commented Feb 5, 2016

They should comment here, marking any concerns with line comments

@Menelion

This comment has been minimized.

Menelion commented Feb 25, 2016

@harpreetkhalsagtbit, any progress on this? Could you mention someone to be the second native speaker?

@Menelion Menelion self-assigned this Feb 25, 2016

@ksr89

This comment has been minimized.

ksr89 commented Feb 29, 2016

@mj1856 @Oire, I have reviewed all locale mapping and verified that this translation related to Punjabi Language, pa-in, is correct and I am willing to support this locale for future revisions.

@Menelion Menelion added this to the 2.12.0 milestone Feb 29, 2016

@Menelion

This comment has been minimized.

Menelion commented Feb 29, 2016

Thanks @ksr89! Staging for the next release.

@ichernev

This comment has been minimized.

Contributor

ichernev commented Mar 6, 2016

Merged in 834a9f3

@ichernev ichernev closed this Mar 6, 2016

ichernev added a commit that referenced this pull request Mar 6, 2016

Merge pull request #2917 from harpreetkhalsagtbit:localePunjabiIndiaF…
…ormatConversion

Locale Punjabi(Gurmukhi) India format conversion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment