Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setters - falsey values #31

Closed
wants to merge 1 commit into from
Closed

setters - falsey values #31

wants to merge 1 commit into from

Conversation

braddunbar
Copy link
Contributor

When using setters with falsey values (e.g. 0) the getter is called instead. This is fixed by a null comparison to use the setter for anything but null and undefined.

@timrwood
Copy link
Member

Ah yes, that slipped by me.

Can you change the pull request to the dev branch though? I'm working on stuff for 1.1.0 and I want this to make it in.

@braddunbar
Copy link
Contributor Author

Sure! I'll just create a new pull request I suppose? I don't see a way to change it retroactively.

@braddunbar braddunbar closed this Oct 25, 2011
butterflyhug pushed a commit to WhoopInc/frozen-moment-OLD that referenced this pull request Jul 22, 2014
Fixed year lower bound from -270,00 to -270,000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants