Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[locale] ca: Improved months and datetime formats #3671

Closed
wants to merge 1 commit into from

Conversation

marcoil
Copy link
Contributor

@marcoil marcoil commented Dec 21, 2016

Pinging previous Catalan committers @pereorga and @juanghurtado.

@pereorga
Copy link
Contributor

Added articles and 'de' to long-form dates.

This is going to cause issues with months that start with a vowel (where d' should be used instead).

Apart from that, patch looks good to me.

@marcoil
Copy link
Contributor Author

marcoil commented Dec 21, 2016

This is going to cause issues with months that start with a vowel (where d' should be used instead).

True, but to me '14 de agost' sounds better than '14 agost'. Unfortunately, I don't see how to implement it correctly at the moment.

@pereorga
Copy link
Contributor

True, but to me '14 de agost' sounds better than '14 agost'. Unfortunately, I don't see how to implement it correctly at the moment.

I agree, and I don't know either.

@ichernev
Copy link
Contributor

ichernev commented Feb 4, 2017

You can use format/standalone versions of months that have the de or d' as part of the month.

grep -r standalone src/locale

Check be, ru, uk locales (among others).

* Changed months abbreviations to the recommended ones
  (https://www.upf.edu/leupf/12ap1/111_3.htm).
* Added articles and "de/d'" to long-form dates.
* Added commas to short-form dates.
@marcoil
Copy link
Contributor Author

marcoil commented Feb 16, 2017

You can use format/standalone versions of months that have the de or d' as part of the month.

I wasn't aware, thanks for the suggestion. I've update the patch with standalone/format month variants.

@ichernev ichernev added this to the 2.18.0 milestone Mar 12, 2017
@ichernev
Copy link
Contributor

Merged in 820a24c

@ichernev ichernev changed the title Improved Catalan localization [locale] ca: Improved months and datetime formats Mar 12, 2017
@ichernev ichernev closed this Mar 12, 2017
ichernev added a commit that referenced this pull request Mar 12, 2017
[locale] ca: Improved months and datetime formats
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants