Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new locale] add en-in: English (India) locale #4626

Closed
wants to merge 3 commits into from

Conversation

kumarharsh
Copy link
Contributor

Closes #4012

@jsf-clabot
Copy link

jsf-clabot commented May 14, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ ashsearle
✅ kumarharsh
❌ punkeel

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 94.763% when pulling 0799c0e on kumarharsh:develop into 3062ca1 on moment:develop.

@coveralls
Copy link

coveralls commented May 14, 2018

Coverage Status

Coverage decreased (-0.3%) to 94.369% when pulling 17f85c0 on kumarharsh:develop into 2e2a5b3 on moment:develop.

@kumarharsh
Copy link
Contributor Author

@marwahaha ping

I also see a bunch of other languages (esp Indian) pending PR due to some extra work which needs to be done - can I clean 'em up and submit a PR?

@marwahaha
Copy link
Member

Hi @kumarharsh - Thanks for this. If you'd like to work on other Indian languages, that sounds great.

@kumarharsh
Copy link
Contributor Author

Updated some comments in the en-in file which were confusing. It's ready for merge I guess.

@kumarharsh
Copy link
Contributor Author

@marwahaha ping?

@marwahaha
Copy link
Member

marwahaha commented Jan 20, 2019

@kumarharsh Your tests are failing:

Module: locale:en-in Test: format
w wo ww ---> 7 7th 07
    at Object.<anonymous> (/home/travis/build/moment/moment/build/umd/test/locale/en-in.js:305:20)
Actual value:
8 8th 08
Expected value:
7 7th 07

I don't know why there is a "diff" from other commits.

@marwahaha marwahaha mentioned this pull request Jan 20, 2019
6 tasks
@ichernev
Copy link
Contributor

en-in was merged in d9913b2

To be fair it differs from this one in both the AM/PM and dow/doy values... You might submit a PR with the changes, but make sure to include some proof of these claims from official sources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing locale 'en-IN'?
7 participants