New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need to declare word 'next' in locale. #4568
Comments
Do you mean there's a Punjabi word missing in the locale file? So, not 'next', but perhaps 'ਅਗਲਾ' ? |
@ashsearle Actually the object [next] makes real sense while telling time in Punjabi. |
@adsingh14 In the context of the line you want to change - the lines above and below all use punjabi, so it seems strange to suggest putting the English word 'next' in there: calendar : {
sameDay : '[ਅਜ] LT',
nextDay : '[ਕਲ] LT',
nextWeek : '[next] dddd, LT', // <-- really?
lastDay : '[ਕਲ] LT',
lastWeek : '[ਪਿਛਲੇ] dddd, LT',
sameElse : 'L'
}, |
Hmm... now that I've just cut'n'pasted that. Are nextDay and lastDay using the same word? That seems a bit confusing... |
I figured it according to the property 'lastWeek'.
That's make sense in Punjabi language. 😅 |
Now I'm really confused: I don't see the word 'prev' anywhere in What are you referring to? I can't read a single thing in punjabi, but checking unicode consortium survey tool and Google Translate, it looks like 'tomorrow' is ਕਲ, and 'yesterday' is ਕੱਲ੍ਹ, so shouldn't it be: nextDay : '[ਕਲ] LT',
lastDay : '[ਕੱਲ੍ਹ] LT', And - assuming we're just failing to communicate - putting the punjabi into nextWeek: nextWeek : '[ਅਗਲਾ] dddd, LT' ? |
@ashsearle ਕੱਲ੍ਹ is same for next & prev day. next is ਅਗਲਾ This is Punjabi grammar. |
@marwahaha i think you've missed that commit from my PR. |
@adsingh14 - does 3062ca1 not address the issue? |
* [misc] release process fixes (moment#4961) * Fix locale abbreviation in comment * Update package-lock.json * [misc] Fix type of WeekSpec (moment#4634) * Fix "the the" typo in test (moment#4578) * [locale] Fix moment#4568: Insert punjabi for "next" (moment#4583) * Fix type of WeekSpec You can set `dow` without setting `doy`, so the type should reflect that * [new locale] (oc-lnc) Occitan (moment#4957) * Add oc-lnc files * Fix calendar test * Fix the rest of tests * Add locale author * Dont make changes to package-lock * Add newline at end of file * [bugfix] Fix moment#4962 updateLocale with null to reset (moment#4966) * [locale] es: Add es translation for invalidDate (moment#4560) * Add es translation for invalidDate * Fix lint * [locale] improve mk translation (moment#4958) * Update mk.js * Update mk.js * Update mk.js * Update mk.js * [locale] improve mk translation * [tests] Fix various text typos (moment#4976) * [locale] mr (Marathi) (moment#4990) * tests according to changes in mr.js * [locale] mr (Marathi) We Marathi people follow standards mentioned below, to label timespans. Label | Time Span ------------ | ------------- पहाटे (post midnight, pre-sunrise) | >= 12am to < 6am सकाळी (post sunrise, pre-noon) | >= 6am to < 12pm दुपारी (afternoon) | >= 12pm to < 5pm सायंकाळी (evening) | >= 5pm to < 8pm रात्री (night) | >= 8pm to < 12am Actually, 12am is confusing in Marathi tradition. In modern clock system, Moment 12am is considered in arriving date as 0am. And in Marathi tradition it is referred to as final moment of the previous date (Sort of, 0:01 is starting minute of the arriving date) . To comply with modern clock system, I propose to refer to 0am as पहाटे , so that it is considered as moment in the arriving date. Hope this discription itself is not confusing :) Another point is about range of पहाटे, ie. >= 0am to < 6am. Though conventionally, upto 2 am, we refer to the time as रात्री or पहाटे, both alternatively, I want to specifically call पहाटे for early times in the arriving date and रात्री for late times in the departing date, to make it more specific and well-defined, avoiding confusion about date of the time. * [locale] correct translation of locale for Vietnam (moment#4874) * correct translation of locale for Vietnam * correct translation of locale for Vietnam (edit proper src files) * Update author comment line * [locale] (en-sg) Rename locale en-SG to en-sg (moment#5025) * [locale] typos in Irish locale for months (moment#5127) Fixed some typos in the Irish locale regarding months. * [locale] (br) Breton move from 12-hour to 24-hour notation (moment#4975) * Breton : move from 12-hour to 24-hour notation moment#4974 moment#4974 * Replace [e] by : * [locale] bn: Improve translation as per Bangla Academy (moment#5055) * Delete unused locales * Remove unused locales * Update test and build * Add untracked locale
Description of the Issue and Steps to Reproduce:
Filepath: [src/locale/pa-in.js]
Please include the values of all variables used.
Need to include object's property(nextWeek) value [next].
current build: nextWeek : 'dddd, LT',
requested change: nextWeek : '[next] dddd, LT',
With Best,
Aman
The text was updated successfully, but these errors were encountered: