[locale] Fix Serbian locale (sr, sr-cyrl) #5742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the grammatical case logic which overlooked some special cases in Serbain language. Also this fixes some grammatical errors concerning cases in Serbian language.
This updates the tests so they will test the new grammar.
|
|
|
approval @crnjakovic ? |
|
I'd have to take a look at this later, I'm at work atm. @marwahaha |
scrnjakovic
reviewed
Oct 8, 2020
scrnjakovic
suggested changes
Oct 8, 2020
scrnjakovic
reviewed
Oct 8, 2020
scrnjakovic
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some login and grammatical errors in Serbian locales (sr, sr-cyrl) and their tests.
Two major problems were logic for getting grammatical cases. It was flawed because it didn't consider special cases for multi-digit numbers, just for single digit special cases.
Along with this, some grammar fixes were made because of different writing of nouns in different tenses (past and future) alongside those without tense (without prefix). Here is some info about that on Wiki. If that's not enough, I'll try to find something that has specific rules about that but I think it's better that other locale contributors look over this.
The tests are adapted to check for new grammar and logic fixes.