Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Remove const usage (fixes #5989, #5996) #5995

Merged
merged 1 commit into from Apr 17, 2022

Conversation

theboolean
Copy link
Contributor

@theboolean theboolean commented Apr 11, 2022

PR #5742 added const usage that is creating dist files containing ES6 syntax, possibly breaking some environments.

First "bugged" version is 2.29.2. Last working version is 2.29.1.

@linux-foundation-easycla
Copy link

@linux-foundation-easycla linux-foundation-easycla bot commented Apr 11, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • login: theboolean / name: Lorenzo Cesana (0de0044)

@theboolean theboolean force-pushed the fix/remove-es6-const-usage branch 2 times, most recently from 978456a to 9683946 Compare Apr 11, 2022
@theboolean theboolean changed the title Fix: Remove const usage bugfix: remove const usage Apr 11, 2022
@theboolean theboolean force-pushed the fix/remove-es6-const-usage branch from 9683946 to a0c4af6 Compare Apr 11, 2022
@theboolean theboolean changed the title bugfix: remove const usage [bugfix] Remove const usage Apr 11, 2022
@theboolean theboolean changed the title [bugfix] Remove const usage [bugfix] Remove const usage (fixes #5989, #5996) Apr 13, 2022
@ichernev
Copy link
Contributor

@ichernev ichernev commented Apr 15, 2022

Thank you @theboolean I'll try to push out 2.29.3 this weekend!

@ichernev ichernev merged commit c5b2334 into moment:develop Apr 17, 2022
4 checks passed
@julix-unity
Copy link

@julix-unity julix-unity commented May 18, 2022

Was curious what caused this... Kindle! - Makes sense - thanks for fixing it. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants