Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] ts: toISOString function also return null #5827

Closed
wants to merge 1 commit into from
Closed

[bugfix] ts: toISOString function also return null #5827

wants to merge 1 commit into from

Conversation

BobZombie
Copy link
Contributor

@BobZombie BobZombie commented Feb 5, 2021 •
edited

toISOString(keep Offset?: boolean) function return string or null.
So, please rewrite moment.d.ts .

@BobZombie BobZombie changed the title toISOString function also return null [bugfix] toISOString function also return null Feb 5, 2021
@ichernev
Copy link
Contributor

Merged in 651dff4

ichernev added a commit that referenced this pull request Dec 24, 2023
@ichernev
Merge pull request #5827 from BobZombie:feature/fix_d.ts
651dff4 
[bugfix] ts: toISOString function also return null
@ichernev ichernev changed the title [bugfix] toISOString function also return null [bugfix] ts: toISOString function also return null Dec 24, 2023
@ichernev ichernev closed this Dec 24, 2023
ichernev added a commit that referenced this pull request Dec 27, 2023
@ichernev
Revert "Merge pull request #5827 from BobZombie:feature/fix_d.ts"
a52ffb2 
This reverts commit 651dff4, reversing
changes made to 8d46db8.
@ichernev
Copy link
Contributor

Sorry, I had to revert this. TS code breaks after the change: #6194

mergify bot pushed a commit to SvenKirschbaum/musikbot-frontend that referenced this pull request Dec 29, 2023
@renovate
Update all non-major dependencies (#163)
b5a101a 
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|---|---|
|  |  | lockFileMaintenance | All locks refreshed | [![age](https://developer.mend.io/api/mc/badges/age///?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption///?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility////?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence////?slim=true)](https://docs.renovatebot.com/merge-confidence/) |
| [@types/react](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react)) | devDependencies | patch | [`17.0.73` -> `17.0.74`](https://renovatebot.com/diffs/npm/@types%2freact/17.0.73/17.0.74) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@types%2freact/17.0.74?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@types%2freact/17.0.74?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@types%2freact/17.0.73/17.0.74?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@types%2freact/17.0.73/17.0.74?slim=true)](https://docs.renovatebot.com/merge-confidence/) |
| [moment](https://momentjs.com) ([source](https://togithub.com/moment/moment)) | dependencies | minor | [`2.29.4` -> `2.30.1`](https://renovatebot.com/diffs/npm/moment/2.29.4/2.30.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/moment/2.30.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/moment/2.30.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/moment/2.29.4/2.30.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/moment/2.29.4/2.30.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) |
| [react-stomp-hooks](https://togithub.com/SvenKirschbaum/react-stomp-hooks) | dependencies | minor | [`2.1.0` -> `2.2.1`](https://renovatebot.com/diffs/npm/react-stomp-hooks/2.1.0/2.2.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/react-stomp-hooks/2.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-stomp-hooks/2.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-stomp-hooks/2.1.0/2.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-stomp-hooks/2.1.0/2.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

🔧 This Pull Request updates lock files to use the latest dependency versions.

---

### Release Notes

<details>
<summary>moment/moment (moment)</summary>

### [`v2.30.1`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#2301)

[Compare Source](https://togithub.com/moment/moment/compare/2.30.0...2.30.1)

-   Release Dec 27, 2023
-   Revert [moment/moment#5827, because it's breaking
    a lot of TS code.

### [`v2.30.0`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#2300-Full-changelog)

[Compare Source](https://togithub.com/moment/moment/compare/2.29.4...2.30.0)

-   Release Dec 26, 2023

</details>

<details>
<summary>SvenKirschbaum/react-stomp-hooks (react-stomp-hooks)</summary>

### [`v2.2.1`](https://togithub.com/SvenKirschbaum/react-stomp-hooks/compare/v2.2.0...v2.2.1)

[Compare Source](https://togithub.com/SvenKirschbaum/react-stomp-hooks/compare/v2.2.0...v2.2.1)

### [`v2.2.0`](https://togithub.com/SvenKirschbaum/react-stomp-hooks/compare/v2.1.0...v2.2.0)

[Compare Source](https://togithub.com/SvenKirschbaum/react-stomp-hooks/compare/v2.1.0...v2.2.0)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 5am on sunday" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/SvenKirschbaum/musikbot-frontend).
mergify bot pushed a commit to SvenKirschbaum/md-frontend that referenced this pull request Dec 31, 2023
@renovate
Update all non-major dependencies (#149)
828ff59 
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|---|---|
|  |  | lockFileMaintenance | All locks refreshed | [![age](https://developer.mend.io/api/mc/badges/age///?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption///?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility////?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence////?slim=true)](https://docs.renovatebot.com/merge-confidence/) |
| [@testing-library/jest-dom](https://togithub.com/testing-library/jest-dom) | devDependencies | patch | [`6.1.5` -> `6.1.6`](https://renovatebot.com/diffs/npm/@testing-library%2fjest-dom/6.1.5/6.1.6) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@testing-library%2fjest-dom/6.1.6?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@testing-library%2fjest-dom/6.1.6?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@testing-library%2fjest-dom/6.1.5/6.1.6?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@testing-library%2fjest-dom/6.1.5/6.1.6?slim=true)](https://docs.renovatebot.com/merge-confidence/) |
| [@testing-library/user-event](https://togithub.com/testing-library/user-event) | devDependencies | patch | [`14.5.1` -> `14.5.2`](https://renovatebot.com/diffs/npm/@testing-library%2fuser-event/14.5.1/14.5.2) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@testing-library%2fuser-event/14.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@testing-library%2fuser-event/14.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@testing-library%2fuser-event/14.5.1/14.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@testing-library%2fuser-event/14.5.1/14.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) |
| [moment](https://momentjs.com) ([source](https://togithub.com/moment/moment)) | dependencies | minor | [`2.29.4` -> `2.30.1`](https://renovatebot.com/diffs/npm/moment/2.29.4/2.30.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/moment/2.30.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/moment/2.30.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/moment/2.29.4/2.30.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/moment/2.29.4/2.30.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

🔧 This Pull Request updates lock files to use the latest dependency versions.

---

### Release Notes

<details>
<summary>testing-library/jest-dom (@&#8203;testing-library/jest-dom)</summary>

### [`v6.1.6`](https://togithub.com/testing-library/jest-dom/releases/tag/v6.1.6)

[Compare Source](https://togithub.com/testing-library/jest-dom/compare/v6.1.5...v6.1.6)

##### Bug Fixes

-   Upgrade [@&#8203;adobe/css-tools](https://togithub.com/adobe/css-tools) to v4.3.2 ([#&#8203;553](https://togithub.com/testing-library/jest-dom/issues/553)) ([b64b953](https://togithub.com/testing-library/jest-dom/commit/b64b953f76170f282c73329ee3479ede13610713))

</details>

<details>
<summary>testing-library/user-event (@&#8203;testing-library/user-event)</summary>

### [`v14.5.2`](https://togithub.com/testing-library/user-event/releases/tag/v14.5.2)

[Compare Source](https://togithub.com/testing-library/user-event/compare/v14.5.1...v14.5.2)

##### Bug Fixes

-   remove interop and deep DTL imports ([6a3c896](https://togithub.com/testing-library/user-event/commit/6a3c896bd2d77d284c6deab4f4f02c0fb366824b))

</details>

<details>
<summary>moment/moment (moment)</summary>

### [`v2.30.1`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#2301)

[Compare Source](https://togithub.com/moment/moment/compare/2.30.0...2.30.1)

-   Release Dec 27, 2023
-   Revert [moment/moment#5827, because it's breaking
    a lot of TS code.

### [`v2.30.0`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#2300-Full-changelog)

[Compare Source](https://togithub.com/moment/moment/compare/2.29.4...2.30.0)

-   Release Dec 26, 2023

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 5am on sunday" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/SvenKirschbaum/md-frontend).
renovate bot added a commit to valora-inc/wallet that referenced this pull request Jan 6, 2024
@renovate
chore(deps): update dependency moment to ^2.30.1 (#4704)
f959343 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [moment](https://momentjs.com)
([source](https://togithub.com/moment/moment)) | [`^2.29.4` ->
`^2.30.1`](https://renovatebot.com/diffs/npm/moment/2.29.4/2.30.1) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/moment/2.30.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/moment/2.30.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/moment/2.29.4/2.30.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/moment/2.29.4/2.30.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>moment/moment (moment)</summary>

###
[`v2.30.1`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#2301)

[Compare
Source](https://togithub.com/moment/moment/compare/2.30.0...2.30.1)

-   Release Dec 27, 2023
- Revert
[moment/moment#5827,
because it's breaking
    a lot of TS code.

###
[`v2.30.0`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#2300-Full-changelog)

[Compare
Source](https://togithub.com/moment/moment/compare/2.29.4...2.30.0)

-   Release Dec 26, 2023

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone
America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone
America/Los_Angeles.

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/valora-inc/wallet).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@nickgraz nickgraz mentioned this pull request Apr 2, 2024
Merged
@Cristy94
Copy link

Cristy94 commented Apr 5, 2024

Sorry, I had to revert this. TS code breaks after the change: #6194

But this would be correct, right?

The Date.toISOString() spec says it either returns a string or throws a RangeError: https://tc39.es/ecma262/multipage/numbers-and-dates.html#sec-date.prototype.toisostring

Should Moment.js do the same?

renovate bot added a commit to openedx/edx-ui-toolkit that referenced this pull request Apr 8, 2024
@renovate
fix(deps): update dependency moment to v2.30.1 (#396)
bd290c3 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [moment](https://momentjs.com)
([source](https://togithub.com/moment/moment)) | [`2.29.4` ->
`2.30.1`](https://renovatebot.com/diffs/npm/moment/2.29.4/2.30.1) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/moment/2.30.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/moment/2.30.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/moment/2.29.4/2.30.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/moment/2.29.4/2.30.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>moment/moment (moment)</summary>

###
[`v2.30.1`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#2301)

[Compare
Source](https://togithub.com/moment/moment/compare/2.30.0...2.30.1)

-   Release Dec 27, 2023
- Revert
[moment/moment#5827,
because it's breaking
    a lot of TS code.

###
[`v2.30.0`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#2300-Full-changelog)

[Compare
Source](https://togithub.com/moment/moment/compare/2.29.4...2.30.0)

-   Release Dec 26, 2023

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on Monday" in timezone
America/New_York, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/openedx/edx-ui-toolkit).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandfresh anandfresh anandfresh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BobZombie @ichernev @Cristy94 @anandfresh