Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore nonessential files when installing via bower #853

Merged
merged 3 commits into from
Jun 18, 2013

Conversation

caged
Copy link
Contributor

@caged caged commented Jun 18, 2013

This pull requests tells bower to ignore all nonessential files and folders (excluding LICENSE and readme.md) so they aren't sent over the wire when installing moment.

Justin Palmer added 2 commits June 18, 2013 11:20
When installing via Bower, we only want to pull down files essential to
the use of moment.js and ignore everything else.  See [ignore]
https://github.com/bower/bower#defining-a-package for more information
on bower ignores.
@timrwood
Copy link
Member

component.json is for Component, not Bower.

I think this is a good addition, but could you change the PR to not delete component.json?

revert back to component.json to keep component/component support
@caged
Copy link
Contributor Author

caged commented Jun 18, 2013

I think this is a good addition, but could you change the PR to not delete component.json?

@timrwood that last commit should do it.

timrwood added a commit that referenced this pull request Jun 18, 2013
Ignore nonessential files when installing via bower
@timrwood timrwood merged commit 79b9f5d into moment:develop Jun 18, 2013
@timrwood
Copy link
Member

Great, thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants