feat: cache client control plane operations #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anitarua
commented
Dec 28, 2023
| @@ -12,7 +12,7 @@ void main() async { | |||
|
|
|||
| var topicClient = TopicClient( | |||
| CredentialProvider.fromEnvironmentVariable("MOMENTO_API_KEY"), | |||
| Mobile.latest()); | |||
| MobileTopicConfiguration.latest()); | |||
There was a problem hiding this comment.
names clashed when both topic and cache configs were exported from the top-level lib/client_sdk_dart.dart file
anitarua
commented
Dec 28, 2023
| CacheConfiguration configuration, Duration defaultTtl) { | ||
| _dataClient = DataClient(credentialProvider, configuration, defaultTtl); | ||
| _controlClient = ControlClient(credentialProvider, configuration); | ||
| // _logger.level = determineLoggerLevel(configuration.logLevel); |
There was a problem hiding this comment.
issue captured in #36
anitarua
commented
Dec 28, 2023
| _logger.finest("initializing cache client"); | ||
| } | ||
|
|
||
| @override | ||
| Future<CreateCacheResponse> createCache(String cacheName) { | ||
| // TODO: add validators |
There was a problem hiding this comment.
will be added in #43 which will also round out all the basic cache operations
Merged
bruuuuuuuce
reviewed
Jan 2, 2024
| class CreateCacheSuccess implements CreateCacheResponse {} | ||
|
|
||
| /// Indicates that the cache already exists, so there was nothing to do. | ||
| class CreateCacheAlreadyExists implements CreateCacheResponse {} |
There was a problem hiding this comment.
How do you feel about the name AlreadyExists instead of CreateCacheAlreadyExists?
There was a problem hiding this comment.
that's definitely more concise, I can change that 👍
| }); | ||
|
|
||
| group('control plane operations', () { | ||
| test('arguments are validated', () { |
There was a problem hiding this comment.
I really like putting these placeholder tests here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #25 and creates integration test setup and teardown functions