Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: scalar delete #43

Merged
merged 10 commits into from
Jan 3, 2024
Merged

feat: scalar delete #43

merged 10 commits into from
Jan 3, 2024

Conversation

anitarua
Copy link
Collaborator

@anitarua anitarua commented Dec 27, 2023 •
edited
Loading

addresses #41

  • adds scalar method for deleting cache items to be on par with swift sdk
  • adds some docstrings to the scalar response classes
  • adds some basic string validators
  • adds scalar integration tests
  • adds missing function for mapping grpc errors to sdk exceptions

anitarua
anitarua commented Dec 27, 2023
View reviewed changes
lib/src/internal/data_client.dart
@@ -41,7 +42,7 @@ class DataClient implements AbstractDataClient {
try {
var resp = await _client.get(request,
options: CallOptions(metadata: {
'cacheName': cacheName,
'cache': cacheName,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

header was misnamed

anitarua
anitarua commented Dec 27, 2023
View reviewed changes
lib/src/cache_client.dart
@@ -23,18 +28,45 @@ class CacheClient implements ICacheClient {
CacheConfiguration configuration, Duration defaultTtl)
: _dataClient =
DataClient(credentialProvider, configuration, defaultTtl) {
_logger.level = determineLoggerLevel(configuration.logLevel);
// TODO: fix logging level issue
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an issue captured in #36

@anitarua anitarua requested review from cprice404 and removed request for cprice404 December 27, 2023 22:37
@anitarua anitarua marked this pull request as draft December 28, 2023 00:17
@anitarua anitarua mentioned this pull request Dec 28, 2023
Merged
@anitarua anitarua marked this pull request as ready for review January 3, 2024 19:43
bruuuuuuuce
bruuuuuuuce approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@bruuuuuuuce bruuuuuuuce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@anitarua anitarua merged commit 2937864 into main Jan 3, 2024
1 check passed
@anitarua anitarua deleted the scalar-delete-and-tests branch January 3, 2024 21:13
@anitarua anitarua mentioned this pull request Jan 3, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruuuuuuuce bruuuuuuuce bruuuuuuuce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anitarua @bruuuuuuuce