Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Menu Drawer Lobby Name Corruption Bug #1098

Merged
merged 1 commit into from Oct 28, 2020
Merged

Fix Menu Drawer Lobby Name Corruption Bug #1098

merged 1 commit into from Oct 28, 2020

Conversation

Gocnak
Copy link
Member

@Gocnak Gocnak commented Oct 28, 2020

This PR fixes a small and rare bug with lobby names being corrupted by improving the logic used to get the lobby name, passing the KeyValues directly in as opposed to returning and using a stack-temporary return value.

Checklist

  • I have thoroughly tested all of the code I have modified/added/removed to ensure something else did not break
  • If there is a localization token change, I have updated the momentum_english_ref.res file with the changes, ran tokenizer.py to generate an up-to-date localization file, and have committed both the .res file changes and the new localization .txt file
  • If I introduced new h/cpp files, I have added them to the appropriate project's VPC file (server_momentum.vpc / client_momentum.vpc / etc)
  • If I have added or modified any visual assets (models, materials, panels, effects, etc), I have taken screenshots / videos of them and attached them to this PR directly (screenshots uploaded through github, videos uploaded to youtube and linked)
  • If I have modified any console command, console variable, or momentum entity, I have opened an issue (or a PR) for it in the Momentum Mod documentation repository
  • My commits are relatively small and scoped to the best of my ability
  • My branch has a clear history of changes that can be easy to follow when being reviewed commit-by-commit
  • My branch is functionally complete; the only changes to be done will be those potentially requested in code review

Should have done this from the start tbh
@Gocnak Gocnak merged commit 0c23415 into develop Oct 28, 2020
@Gocnak Gocnak deleted the fix/lobby-names branch October 28, 2020 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants