Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix certain commands going through mapfinished panel #1125

Merged
merged 1 commit into from Nov 1, 2020
Merged

Fix certain commands going through mapfinished panel #1125

merged 1 commit into from Nov 1, 2020

Conversation

ijre
Copy link
Member

@ijre ijre commented Oct 31, 2020

Closes #1091

This PR fixes specific commands going through the mapfinished panel even when mom_mapfinished_movement_enable is false.

Checklist

  • I have thoroughly tested all of the code I have modified/added/removed to ensure something else did not break
  • If there is a localization token change, I have updated the momentum_english_ref.res file with the changes, ran tokenizer.py to generate an up-to-date localization file, and have committed both the .res file changes and the new localization .txt file
  • If I introduced new h/cpp files, I have added them to the appropriate project's VPC file (server_momentum.vpc / client_momentum.vpc / etc)
  • If I have added or modified any visual assets (models, materials, panels, effects, etc), I have taken screenshots / videos of them and attached them to this PR directly (screenshots uploaded through github, videos uploaded to youtube and linked)
  • If I have modified any console command, console variable, or momentum entity, I have opened an issue (or a PR) for it in the Momentum Mod documentation repository
  • My commits are relatively small and scoped to the best of my ability
  • My branch has a clear history of changes that can be easy to follow when being reviewed commit-by-commit
  • My branch is functionally complete; the only changes to be done will be those potentially requested in code review

@Gocnak Gocnak merged commit 4cf5db4 into momentum-mod:develop Nov 1, 2020
@ijre ijre deleted the fix-mapfinish-bypass branch November 1, 2020 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some user inputs bypass map finish panel and go to game
2 participants