New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update player's name on user components and lobby members panel #1164
Conversation
Doesn't |
It does, didn't realize that. Makes things much nicer :D. Didn't realize the avatar panel does this so just need to focus on names here. TF2 should do this.. they only update player name on main menu when doing certain actions :x |
aab17f9
to
b613808
Compare
mp/src/game/client/momentum/ui/gameui/mainmenu/drawer/lobby/LobbyMembersPanel.cpp
Outdated
Show resolved
Hide resolved
mp/src/game/client/momentum/ui/gameui/mainmenu/drawer/lobby/LobbyMembersPanel.h
Outdated
Show resolved
Hide resolved
b613808
to
034af27
Compare
I moved the lobby callback to |
963cb05
to
4cff1d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually slight change I noticed
Only works if you are friends with them though.
4cff1d9
to
64f7b80
Compare
Closes #1162
Unfortunately there's no steam callback for changing names (at least from what I read of the steamworks API), so I took the approach of just updating it more often.
OnPageShow
isn't being called when opening the drawer though. Intentional?SetUser
sets the steam name then callsFillControlsWithUserData
that overwrites it with the one in user data). Result though is us not using the locally stored username.Checklist
momentum_english_ref.res
file with the changes, rantokenizer.py
to generate an up-to-date localization file, and have committed both the.res
file changes and the new localization.txt
fileserver_momentum.vpc
/client_momentum.vpc
/ etc)