-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
esbuild-bundle-analyzerが正しくファイルを認識するようにした #739
base: main
Are you sure you want to change the base?
Conversation
PR #725 (CIの修正PR)を受け入れたあとにrebaseする |
760e713
to
21afd27
Compare
他のPRでAddedになってたときのActions見ると、なんかエラーでてるな。 https://github.com/momocus/sakazuki/actions/runs/9561872704 ...
▶Run exoego/esbuild-bundle-analyzer@v1
▶Run dawidd6/action-download-artifact@v3
==> Repository: momocus/sakazuki
==> Artifact name:
==> Local path: .analyzer/base
==> Workflow name: 995021[10](https://github.com/momocus/sakazuki/actions/runs/9561872704/job/26357032994#step:6:11)
==> Workflow conclusion: success
==> Branch: main
==> Allow forks: true
Error: no matching workflow run found with any artifacts?
Run node /home/runner/work/_actions/exoego/esbuild-bundle-analyzer/v1/dist/index.mjs
Wrote /home/runner/work/sakazuki/sakazuki/.analyzer/bundle_analysis.json {
'meta.json -> app/assets/builds/application.js': {
bytes: 1007464,
metafile: 'meta.json',
outfile: 'app/assets/builds/application.js'
}
}
▶Run node /home/runner/work/_actions/exoego/esbuild-bundle-analyzer/v1/dist/index.mjs
... |
このPRで起動したActionsではエラーでてない。 |
21afd27
to
37e36db
Compare
📦 esbuild Bundle Analysis for sakazukiThis analysis was generated by esbuild-bundle-analyzer. 🤖 |
37e36db
to
e834345
Compare
rebase後もやはりのーあーてぃふぁくとエラーは出てる。 |
そもそもmainブランチの内容を保存しておかないといけないのでは。 |
PR時に比較対象であるmainブランチを解析する必要がある。 そのために、push mainをトリガーに追加した。
e834345
to
760591b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #739 +/- ##
=======================================
Coverage 96.57% 96.57%
=======================================
Files 17 17
Lines 321 321
=======================================
Hits 310 310
Misses 11 11 ☔ View full report in Codecov by Sentry. |
fix #736
やったこと