ci: fork から PR が来たとき esbuild-bundle-analyzer がコケるのを修正 #725
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Action のセキュリティ上の制限として、fork からプルリクに対する
pull_request
イベントでは、GITHUB_TOKEN
にpull-request
scope への write 権限が付与されません。esbuild-bundle-analyzer は pull-request にコメントを書き込むため、write 権限が必要です。
fork からのプルリクでも
GITHUB_TOKEN
に write 権限を与えるためには、pull_request_target
という別のイベントを明示する必要があるようです。注:
この PR は初めての
pull_request_target
の追加なので、マージされるまで発火しないようです。このような変更をマージしたあと、fork から来た PR で
pull_request_target
が発火しているのは exoego/esbuild-bundle-analyzer#43 で確認できます