one last set of lil tweaks

monarch-initiative · Aug 22, 2023 · ec7c514 · ec7c514
1 parent af068d6
commit ec7c514
Show file tree

Hide file tree

Showing 7 changed files with 20 additions and 17 deletions.
diff --git a/backend/tests/fixtures/association_counts_response.py b/backend/tests/fixtures/association_counts_response.py
@@ -5,7 +5,7 @@
 def association_counts_response():
     return {
         "responseHeader": {
-            "QTime": 1,
+            "QTime": 0,
             "params": {
                 "facet.query": [
                     '(category:"biolink:DiseaseToPhenotypicFeatureAssociation") AND (subject:"MONDO:0020121" OR subject_closure:"MONDO:0020121")',

diff --git a/backend/tests/fixtures/association_table_response.py b/backend/tests/fixtures/association_table_response.py
@@ -5,7 +5,7 @@
 def association_table_response():
     return {
         "responseHeader": {
-            "QTime": 1,
+            "QTime": 0,
             "params": {
                 "mm": "100%",
                 "q": "*:*",

diff --git a/backend/tests/fixtures/phenotype_explorer_compare.py b/backend/tests/fixtures/phenotype_explorer_compare.py
@@ -5,11 +5,11 @@
 def phenotype_explorer_compare():
     return {
         "subject_termset": {
-            "MP:0010771": {"id": "MP:0010771", "label": "integument phenotype (MPO)"},
             "MP:0002169": {
                 "id": "MP:0002169",
                 "label": "no abnormal phenotype detected (MPO)",
             },
+            "MP:0010771": {"id": "MP:0010771", "label": "integument phenotype (MPO)"},
         },
         "object_termset": {"HP:0004325": {"id": "HP:0004325", "label": "Decreased body weight (HPO)"}},
         "subject_best_matches": {
@@ -35,6 +35,7 @@ def phenotype_explorer_compare():
                     "subject_information_content": None,
                     "ancestor_information_content": 1.5616002210519475,
                     "jaccard_similarity": 0.16216216216216217,
+                    "cosine_similarity": None,
                     "dice_similarity": None,
                     "phenodigm_score": 0.5032220864376823,
                 },
@@ -61,6 +62,7 @@ def phenotype_explorer_compare():
                     "subject_information_content": None,
                     "ancestor_information_content": 2.2728188647181566,
                     "jaccard_similarity": 0.325,
+                    "cosine_similarity": None,
                     "dice_similarity": None,
                     "phenodigm_score": 0.8594568814276845,
                 },
@@ -89,6 +91,7 @@ def phenotype_explorer_compare():
                     "subject_information_content": None,
                     "ancestor_information_content": 2.2728188647181566,
                     "jaccard_similarity": 0.325,
+                    "cosine_similarity": None,
                     "dice_similarity": None,
                     "phenodigm_score": 0.8594568814276845,
                 },

diff --git a/backend/tests/fixtures/search_response.py b/backend/tests/fixtures/search_response.py
@@ -5,7 +5,7 @@
 def search_response():
     return {
         "responseHeader": {
-            "QTime": 1,
+            "QTime": 0,
             "params": {
                 "mm": "100%",
                 "q": "fanconi",

diff --git a/backend/tests/unit/test_fixtures.py b/backend/tests/unit/test_fixtures.py
@@ -15,9 +15,6 @@ def test_autocomplete(autocomplete):
 
 def test_compare(compare):
     tsps = TermSetPairwiseSimilarity(**compare)
-    import pprint
-
-    pprint.PrettyPrinter(indent=2).pprint(tsps.dict())
     assert len(tsps.subject_best_matches) != 0
 
 

diff --git a/frontend/fixtures/phenotype-explorer-compare.json b/frontend/fixtures/phenotype-explorer-compare.json
@@ -1,12 +1,12 @@
 {
   "subject_termset": {
-    "MP:0010771": {
-      "id": "MP:0010771",
-      "label": "integument phenotype (MPO)"
-    },
     "MP:0002169": {
       "id": "MP:0002169",
       "label": "no abnormal phenotype detected (MPO)"
+    },
+    "MP:0010771": {
+      "id": "MP:0010771",
+      "label": "integument phenotype (MPO)"
     }
   },
   "object_termset": {
@@ -38,6 +38,7 @@
         "subject_information_content": null,
         "ancestor_information_content": 1.5616002210519475,
         "jaccard_similarity": 0.16216216216216217,
+        "cosine_similarity": null,
         "dice_similarity": null,
         "phenodigm_score": 0.5032220864376823
       }
@@ -64,6 +65,7 @@
         "subject_information_content": null,
         "ancestor_information_content": 2.2728188647181566,
         "jaccard_similarity": 0.325,
+        "cosine_similarity": null,
         "dice_similarity": null,
         "phenodigm_score": 0.8594568814276845
       }
@@ -92,6 +94,7 @@
         "subject_information_content": null,
         "ancestor_information_content": 2.2728188647181566,
         "jaccard_similarity": 0.325,
+        "cosine_similarity": null,
         "dice_similarity": null,
         "phenodigm_score": 0.8594568814276845
       }

diff --git a/frontend/src/pages/node/AssociationsTable.vue b/frontend/src/pages/node/AssociationsTable.vue
@@ -241,12 +241,12 @@ const {
   isLoading,
   isError,
 } = useQuery(
-  async function () /**
-   * whether to perform "fresh" search, without filters/pagination/etc. true when
-   * search text changes, false when filters/pagination/etc change.
-   */
-  // fresh: boolean,
-  {
+  async function (
+    fresh: boolean /**
+     * whether to perform "fresh" search, without filters/pagination/etc. true when
+     * search text changes, false when filters/pagination/etc change.
+     */,
+  ) {
     /** catch case where no association categories available */
     if (!props.node.association_counts.length)
       throw new Error("No association info available");